Update LDE Node Pool Assertion and Test env variable Handling #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
lgarber-akamai
approved these changes
May 13, 2025
zliang-akamai
approved these changes
May 16, 2025
vshanthe
added a commit
that referenced
this pull request
May 23, 2025
* fix the failing test in TOD for Ansible_linode (#667) * adding blank line * fix_test * Cleanup unnecessary steps in release workflow (#668) * Add DBaaS Suspend and Resume (#659) ## 📝 Description **What does this PR do and why is this change necessary?** Allows suspending and resuming a database via the status field in ansible ## ✔️ How to Test **How do I run the relevant unit/integration tests?** ```bash make test-int TEST_SUITE="database_postgresql_v2_basic" ``` ```bash make test-int TEST_SUITE="database_mysql_v2_basic" ``` * Support Object Storage Quota modules (#671) * obj quota * fix doc * remove v4beta * Update LDE Node Pool Assertion and Test env variable Handling (#673) * better test env var handling * update test assertion * add safety * update assertion * build(deps): bump slackapi/slack-github-action from 2.0.0 to 2.1.0 (#672) Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v2.0.0...v2.1.0) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Project: Configurable DB Params (#678) * Configurable DB Parameters: Implementation (#670) * Add support for Configurable DB Parameters * revert instance.rst * tidy up * oops * add and update test cases * Revert branch change * remove pg13 negative test case --------- Co-authored-by: Youjung Kim <[email protected]> * Point to latest version of Python SDK * Added documentation links --------- Co-authored-by: Lena Garber <[email protected]> Co-authored-by: Youjung Kim <[email protected]> * Respond to parse_linode_types(...) change in instance module (#680) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]> Co-authored-by: Jacob Riddle <[email protected]> Co-authored-by: Ye Chen <[email protected]> Co-authored-by: Youjung Kim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Zilber <[email protected]> Co-authored-by: Lena Garber <[email protected]> Co-authored-by: Youjung Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Address assertion failure, changed it to be more flexible asserting if lde has an explicitly set value upon cluster creation
Now makefile uses LINODE_ env vars if set, falls back to TEST_ if not, and finally uses hardcoded defaults when neither is available — making the setup more consistent with other repositories
✔️ How to Test
Test environment variables:
Test LKE assertion changes:
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.